Action #1110
Feature #1036: Implement energy resolution
Write a test case
| Status: | Closed | Start date: | 12/10/2013 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned To: |  Owen Ellis | % Done: | 100% | |
| Category: | - | |||
| Target version: | Stage Florent | |||
| Duration: |
Recurrence
No recurrence.
History
#1
Updated by Deil Christoph over 10 years ago
- Status changed from New to In Progress
- Assigned To set to Owen Ellis
#2
Updated by Owen Ellis about 10 years ago
- % Done changed from 0 to 50
https://github.com/ellisowen/gammalib/tree/action_1105_b
currently a bug in the unit test - I’m working on this at the moment to resolve the issue.
#3
Updated by Knödlseder Jürgen about 10 years ago
- % Done changed from 50 to 60
On the flight back I implemented the integration in GCTAResponse::nedisp which does basically the same as your unit test. While doing this I recognized that there were some errors in the function computation, which I corrected. Now the energy dispersion integrated to unity.
I merged in your action_1105_b, did some minor cosmetic adjustments, and this now also seems to work. So you may close the issue, unless you want to add more testing steps.
I merged the 1036-implement-energy-resolution branch into integration, as I worked in the meanwhile on the GCaldb class, and this led to a divergence of the code. So CTA energy dispersion is now implemented in GammaLib!
Still needs some testing, but at least everything compiles and all unit tests are okay.
#4
Updated by Deil Christoph about 10 years ago
- Status changed from In Progress to Resolved
- % Done changed from 60 to 100
#5
Updated by Knödlseder Jürgen about 10 years ago
- Status changed from Resolved to Feedback
#6
Updated by Knödlseder Jürgen almost 10 years ago
- Target version deleted (
2nd coding sprint)
#7
Updated by Knödlseder Jürgen over 9 years ago
- Status changed from Feedback to Closed
- Remaining (hours) set to 0.0
#8
Updated by Knödlseder Jürgen about 9 years ago
- Target version set to Stage Florent