Action #1114

Implement 3D access for GCTAResponseTable

Added by Mayer Michael about 10 years ago. Updated almost 10 years ago.

Status:ClosedStart date:01/28/2014
Priority:NormalDue date:
Assigned To:Gerard Lucie% Done:

100%

Category:-
Target version:00-09-00
Duration:

Description

GCTAResponseTable currently only allows to access and interpolate in at most 2 dimensions. Related to issue #1096, we should be able to access e.g. the background as function of X,Y and Energy.


Recurrence

No recurrence.

History

#1 Updated by Gerard Lucie about 10 years ago

  • Status changed from New to Pull request
  • Assigned To set to Gerard Lucie
  • % Done changed from 0 to 100

currently available in branch 1096-CTABack_from_inst_coord
test unit for this is needed

#2 Updated by Knödlseder Jürgen about 10 years ago

  • Status changed from Pull request to Feedback
  • Target version set to 2nd coding sprint

Looks like this is already merged into devel. Please let me know if something is missing.

#3 Updated by Gerard Lucie about 10 years ago

the only thing that is missing here are test units

#4 Updated by Knödlseder Jürgen about 10 years ago

Have they already been implemented (i.e. have I missed them in the merge), or is this work to be done?

#5 Updated by Gerard Lucie about 10 years ago

they have been implemented

#6 Updated by Knödlseder Jürgen about 10 years ago

Already pushed into git?

When I merge in the branch I get

$ git merge origin/1096-CTABack_from_inst_coord
Already up-to-date.

and when I look into the CTA test suite I cannot find unit tests for the CTA response table.

So please check whether you have code on your side that is not yet in the devel branch. If not we can consider the issue as closed.

#7 Updated by Gerard Lucie about 10 years ago

no I meant the interpolation is ready. The test units have to be written. They are not ready.

#8 Updated by Knödlseder Jürgen about 10 years ago

Gerard Lucie wrote:

no I meant the interpolation is ready. The test units have to be written. They are not ready.

Got it ;)

#9 Updated by Knödlseder Jürgen almost 10 years ago

  • Status changed from Feedback to Resolved
  • Target version changed from 2nd coding sprint to 00-09-00

#10 Updated by Knödlseder Jürgen almost 10 years ago

  • Status changed from Resolved to Closed
  • Remaining (hours) set to 0.0

Also available in: Atom PDF