Bug #1277
Units of m_detx m_dety seem to be degs instead of radians
| Status: | Closed | Start date: | 07/12/2014 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned To: |  Knödlseder Jürgen | % Done: | 100% | |
| Category: | - | |||
| Target version: | 3rd coding sprint | |||
| Duration: |
Description
While the code description says that detx, and dety are in units of radians, it seems that they are actually in units of degree.
Example:
cta = GCTAObservation()
cta.load('run_0023592_std_eventlist.fits')
events = GCTAEventList(cta.events())
event = events[0]
detx = event.dir().detx()
dety = event.dir().dety()
In [57]: detx
Out[57]: 0.3536582589149475
In [58]: dety
Out[58]: -0.01053939200937748
Recurrence
No recurrence.
History
#1
Updated by Lu Chia-Chun over 10 years ago
Sorry, forgot to say. m_detx and m_dety are members in GCTAInstDir
#2
Updated by Knödlseder Jürgen over 10 years ago
- Status changed from New to Feedback
- Assigned To set to Knödlseder Jürgen
- Target version set to 3rd coding sprint
- % Done changed from 0 to 100
Indeed, the reader and writer in GCTAEventList was missing the conversions. I have not recognized because GammaLib is so far not using this information. I have now corrected. Could you please check?
#3
Updated by Knödlseder Jürgen over 10 years ago
- Description updated (diff)
#4
Updated by Lu Chia-Chun over 10 years ago
- Status changed from Feedback to Resolved
Now it’s correct. We can close this issue.
#5
Updated by Knödlseder Jürgen over 10 years ago
- Status changed from Resolved to Closed