Bug #1432

GCTAPsfKing has undefined behavior when psf parameters are 0.0

Added by Kelley-Hoskins Nathan over 9 years ago. Updated over 9 years ago.

Status:ClosedStart date:03/03/2015
Priority:NormalDue date:
Assigned To:Kelley-Hoskins Nathan% Done:

100%

Category:-
Target version:1.0.0
Duration:

Description

In GCTAPsfKing, if the read-in gamma/sigma parameters are 0, due to either low statistics or bad fitting, then update() or operator() may attempt to divide by zero.


Recurrence

No recurrence.

History

#1 Updated by Kelley-Hoskins Nathan over 9 years ago

  • Status changed from New to Pull request
  • % Done changed from 0 to 100

In branch 1432-fix_psf_king_zero_params, added a check for if the king parameters gamma and sigma are zero. If they are, give a warning message, and set the normalization to zero.

#2 Updated by Mayer Michael over 9 years ago

Jürgen, could you merge that in?

#3 Updated by Knödlseder Jürgen over 9 years ago

  • Status changed from Pull request to Closed
  • Target version set to 1.0.0

Merged into devel.

Also available in: Atom PDF