Change request #1818

Rename the spatial component names

Added by Knödlseder Jürgen over 6 years ago. Updated over 6 years ago.

Status:ClosedStart date:07/18/2016
Priority:UrgentDue date:
Assigned To:Knödlseder Jürgen% Done:

80%

Category:-
Target version:1.1.0
Duration:

Description

Use the following names for spatial components in the XML file:
  • “PointSource” (alias: “SkyDirFunction”)
  • “RadialDisk” (alias: “DiskFunction”)
  • “RadialGaussian” (alias: “GaussianFunction”)
  • “RadialShell” (alias: “ShellFunction”)
  • “EllipticalDisk”
  • “EllipticalGaussian” (alias: “EllipticalGauss”)
  • “DiffuseIsotropic” (alias: “ConstantValue”)
  • “DiffuseMap” (alias: “SpatialMap”)
  • “DiffuseMapCube” (alias: “MapCubeFunction”)

Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen over 6 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80

Implemented the new names. The old names are still supported. Support for the old names can be turned off by specifying

./configure --disable-legacy-xml-format

#2 Updated by Knödlseder Jürgen over 6 years ago

The following names are used for spatial components in the XML file:
  • “PointSource” (alias: “SkyDirFunction”)
  • “RadialDisk” (alias: “DiskFunction”)
  • “RadialGaussian” (alias: “GaussFunction”)
  • “RadialShell” (alias: “ShellFunction”)
  • “EllipticalDisk”
  • “EllipticalGaussian” (alias: “EllipticalGauss”)
  • “DiffuseIsotropic” (alias: “ConstantValue”)
  • “DiffuseMap” (alias: “SpatialMap”)
  • “DiffuseMapCube” (alias: “MapCubeFunction”)

#3 Updated by Mayer Michael over 6 years ago

Sounds good. Would it make sense to rename “DiffuseMapCube” to “DiffuseCube”? The latter sounds more unambiguous.

#4 Updated by Knödlseder Jürgen over 6 years ago

Mayer Michael wrote:

Sounds good. Would it make sense to rename “DiffuseMapCube” to “DiffuseCube”? The latter sounds more unambiguous.

“Cube” does not really specify what kind of cube it is, “Map Cube” is more explicit.

#5 Updated by Knödlseder Jürgen over 6 years ago

  • Status changed from In Progress to Closed

Merged into devel.

Also available in: Atom PDF