Feature #2142

GGti::exclude(tstart,tstop)

Added by Kelley-Hoskins Nathan almost 7 years ago. Updated over 6 years ago.

Status:NewStart date:06/29/2017
Priority:NormalDue date:
Assigned To:-% Done:

0%

Category:-
Target version:-
Duration:

Description

GGti has an extend() function for expanding the gti, but if you want to exclude a time region (maybe partially or completely inside the gti), theres no simple function to do that.


Recurrence

No recurrence.

History

#1 Updated by Kelley-Hoskins Nathan almost 7 years ago

And I guess while we’re modifying the GGti code, the ontime doesn’t update when the time intervals are changed (for example, via GGti::clear(), then GGti::append() ). I would suggest adding a GGti::ontime(double) function for this.

#2 Updated by Knödlseder Jürgen over 6 years ago

Kelley-Hoskins Nathan wrote:

And I guess while we’re modifying the GGti code, the ontime doesn’t update when the time intervals are changed (for example, via GGti::clear(), then GGti::append() ). I would suggest adding a GGti::ontime(double) function for this.

We need to correct that. I would however not add an ontime setter method since then the results can be inconsistent. The aim of the ontime method is to avoid computation of the ontime by hand, but it should always just return the sum of all GTIs.

However, I checked the GGti class and could not see any problem with the setting of the ontime. Could you please give an explicit example where the ontime method does not return the correct value?

I recognize however that if you use overlapping time intervals, the ontime will not be set correctly. The GGti class does not handle for the moment overlapping time intervals, and it also assumes that time intervals are always in order. This should be improved. I created issue #2173 for that.

#3 Updated by Knödlseder Jürgen over 6 years ago

  • Related to Bug #2171: csresmap fails when a residual map is computed for a counts cube and a model containing a diffuse map or cube added

#4 Updated by Knödlseder Jürgen over 6 years ago

  • Related to Change request #2173: Guarantee consistency of Good Time Intervals in the GGti class added

#5 Updated by Knödlseder Jürgen over 6 years ago

  • Related to deleted (Bug #2171: csresmap fails when a residual map is computed for a counts cube and a model containing a diffuse map or cube)

#6 Updated by Knödlseder Jürgen over 6 years ago

  • Related to deleted (Change request #2173: Guarantee consistency of Good Time Intervals in the GGti class)

Also available in: Atom PDF