Change request #2695
Allow RoI centres different from pointing direction in unbinned analysis
| Status: | Closed | Start date: | 10/08/2018 | |
|---|---|---|---|---|
| Priority: | Urgent | Due date: | ||
| Assigned To: |  Knödlseder Jürgen | % Done: | 100% | |
| Category: | - | |||
| Target version: | 1.7.0 | |||
| Duration: |
Description
So far the npred() methods of GCTAModelAeffBackground, GCTAModelIrfBackground and GCTAModelBackground assume that the RoI centre is identical to the pointing direction. Although this may often be the case, the more general case of a different RoI centre should be covered. For now, an exception will be thrown in the pointing direction differs from the RoI centre.
Recurrence
No recurrence.
Related issues
History
#1
Updated by Knödlseder Jürgen about 6 years ago
- Related to Feature #2694: Implement more complex background models for H.E.S.S. data analysis added
#2
Updated by Knödlseder Jürgen almost 6 years ago
- Target version deleted (
1.6.0)
Postpone to release after 1.6.0
#3
Updated by Knödlseder Jürgen almost 5 years ago
- Assigned To set to Knödlseder Jürgen
- Priority changed from Normal to Urgent
- Target version set to 1.7.0
#4
Updated by Knödlseder Jürgen over 4 years ago
- Status changed from New to Pull request
- % Done changed from 0 to 100
GCTAModelAeffBackgroundGCTAModelIrfBackgroundGCTAModelSpatial
Note that GCTAModelRadialAcceptance allowed already RoI centres differents from the pointing direction. I therefore wrote a script inst/cta/test/dev/test_background_npred.py that compares the npred computation for RoI centre different from the pointing direction between GCTAModelRadialAcceptance and GCTAModelSpatial models that are intrinsically identical. Within a relative precision of 1e-4, the results were indeed identical.
#5
Updated by Knödlseder Jürgen over 4 years ago
- Status changed from Pull request to Closed
Merged into devel.