Action #331

Feature #56: CTA response should support diffuse models (skymaps)

Factorise GCTAResponse

Added by Knödlseder Jürgen over 12 years ago. Updated over 12 years ago.

Status:ClosedStart date:02/28/2012
Priority:NormalDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-Estimated time:8.00 hours
Target version:-
Duration:

Description

Factorise GCTAResponse class as the file GCTAResponse.cpp becomes a long monolithic file that will be difficult to maintain.

One option is to separate the code for extended sources and diffuse sources in separate files. Also the helper classes that are used for integration should be split into separate files. We probably should also rename the helper classes so that they have unique names.

Another option is to add the helper classes for integration to the GCTASupport file. The disadvantage of this option is that specific classes would no longer belong to specific files. Maybe this is more confusing.


Recurrence

No recurrence.


Related issues

Related to GammaLib - Feature #104: Refactor CTA response class Closed 07/20/2012

History

#1 Updated by Knödlseder Jürgen over 12 years ago

  • Description updated (diff)

#2 Updated by Knödlseder Jürgen over 12 years ago

  • Status changed from New to In Progress

#3 Updated by Knödlseder Jürgen over 12 years ago

  • % Done changed from 0 to 30

The integration kernel classes have now been defined externally of the GCTAResponse class, and they have been exported in a separate file names GCTAResponse_helpers. Extended and diffuse model helper classes are together in this file.

#4 Updated by Knödlseder Jürgen over 12 years ago

  • Remaining (hours) changed from 8.0 to 7.0

#5 Updated by Knödlseder Jürgen over 12 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 30 to 100
  • Remaining (hours) changed from 7.0 to 0.0

The refactorisation of the extended and diffuse response methods has been finished.

What is still remaining is the refactorisation of the Aeff and PSF classes. See feature #104 for this additional work.

#6 Updated by Knödlseder Jürgen over 12 years ago

  • Target version deleted (Stage Jean-Baptiste Cayrou)

Also available in: Atom PDF