Bug #3552
Avoid FITS rounding errors in GWcs::compare method
| Status: | Closed | Start date: | 02/24/2021 | |
|---|---|---|---|---|
| Priority: | Immediate | Due date: | ||
| Assigned To: |  Knödlseder Jürgen | % Done: | 100% | |
| Category: | - | |||
| Target version: | 2.0.0 | |||
| Duration: |
Description
When writing and reading back the WCS definition from a FITS file rounding errors may occur in GWcs::compare due to the finit precision of floating point values in the FITS header. A tolerance should be added for the comparison of two floating point values.
Recurrence
No recurrence.
History
#1
Updated by Knödlseder Jürgen almost 4 years ago
- Status changed from New to Pull request
- % Done changed from 0 to 90
I added the gammalib::compare() function to compare two floating point values with tolerance. However, I could not reproduce the issue with the WCS definition rounding errors, hence I did not implement any modification of the WCS comparison methods.
#2
Updated by Knödlseder Jürgen almost 4 years ago
- Status changed from Pull request to Closed
- % Done changed from 90 to 100
Merged into devel.