Change request #4058

Add ASTRI as supported instrument type for the CTA module

Added by Knödlseder Jürgen almost 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:05/25/2022
Priority:NormalDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-
Target version:2.0.0
Duration:

Description

So far, ASTRI is not explicitly supported as gamma-ray instrument in the CTA module. ASTRI should be added as an additional instrument, and specifically, astri should be supported as a separate caldb entry. See the following exchange with Pat Romano for details:

Dear Pat,

Thanks for your message.

Indeed, the “cta” string is hardcoded (I think in a single place), and I think it would be pretty easy to change the code so that “astri” would be used in case that an ASTRI observation is concerned. For that purpose I would propose that we introduce “ASTRI” as a new possible instrument name to be used in an XML file as instrument attribute. “ASTRI” should then also be used as the TELESCOP keyword in the FITS files so that when reading a FITS file it will automatically generate an ASTRI observation. Probably an instrument parameter should also be added to ctobssim, so that simulations can also be performed for ASTRI data. Maybe a few other minor tweeks are needed.

If this sounds reasonable for you I would go ahead and make some changes to the ctools/GammaLib 2.0.0.dev version you can test then on your side before I release the new 2.0.0 ctools version.

Ciao,
Jürgen

Le 24 mai 2022 à 12:10, Pat Romano <> a écrit :

Dear Jurgen,

I am working on creating the ASTRI caldb-style IRF distribution.
I have been simulating ASTRI data with ctools for a three
years now, but so far, just to be quick, I had put the ASTRI IRFs
in a mock cta distribution, like

/usr/local/caldb_ctools/caldb_astri_ma/data/cta/prod3b/bcf/

Now, however, we have the first bunch of IRFs to distribute to
the scientific community and I’d like to provide a proper path
for the caldb... but it looks like ctools expects “cta”
to be in the path.

I saw in the FAQs that ctools is not meant for other telescopes,
but I was hoping the selection would not be so strict...
Is there any hope that in the future at least the look-up for the
IRFs would not be CTA-specific?
I can certainly create two caldb distributions, one for ctools
users and one for gammapy users, but it would be cleaner to just
have one :)

Thanks!
Cheer,
Pat


Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen almost 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50

I added ASTRI to the possible instruments in GCTAObservation and GCTAOnOffObservation.

In addition, the GCTAResponseIrf::read now try to extract the instrument from the XML instrument attribute, and only if no such attribute was found, cta will be assumed as default instrument. This should allow specifying different instruments in the observation definition XML file that will then search in the corresponding caldb for the specified response.

In the ctool::create_cta_obs method I added the optional reading of the instrument parameter and the setting of the corresponding instrument member of the GCTAObservation instance. To use this functionality, I added instrument parameters to ctobssim and ctmodel.

I furthermore added ASTRI to the possible instruments in ctbkgcube::process.

Finally, I assigned the first valid instrument in the ctbin::obs_cube_stacked method to the stacked observation. This allows then also stacking of ASTRI observations.

#2 Updated by Knödlseder Jürgen almost 2 years ago

  • % Done changed from 50 to 60
I added also support for FACT, and added ASTRI and FACT as possible instruments to the parameter files of the following cscripts:
  • csebins
  • csobsdef
  • cspull
  • cssens
  • cstsdist

#3 Updated by Knödlseder Jürgen almost 2 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 60 to 100

#4 Updated by Knödlseder Jürgen almost 2 years ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF