GammaLib

I just tried running the api-sanity-checker on my Mac against gammalib built with clang.

Compared to the results at https://cta-jenkins.irap.omp.eu/job/gammalib-sanity/ there’s an additional segfault in the `GIntegral::polint` test:

#include <stdlib.h>
#include <gammalib/GammaLib.hpp>

class GIntegrand_SubClass: public GIntegrand
{
public:
    GIntegrand_SubClass():GIntegrand(){}

    double eval(double x) {
       return 6.5;
    }
};//GIntegrand_SubClass

class GIntegral_SubClass: public GIntegral
{
public:
    GIntegral_SubClass(GIntegrand* integrand):GIntegral(integrand){}

    double polint_Wrapper() {
       double* xa = (double*) malloc(sizeof(double)*256);
       double ya [] = {
           1.5,
           2.5,
           3.5,
           4.5};
       double* dy = (double*) malloc(sizeof(double)*256);
       return this->polint(
          xa,
          ya,
          256,
          5.5,
          dy);
    }
};//GIntegral_SubClass

int main(int argc, char *argv[])
{
    GIntegrand_SubClass* integrand = new GIntegrand_SubClass();
    GIntegral_SubClass* integral = new GIntegral_SubClass(integrand);
    integral->polint_Wrapper(); //target call
    return 0;
}

I didn’t investigate what the actual problem is, here’s what Valgrind has to say (on Ubuntu, Valgrind is pretty broken on Mac OS X 10.8):

deil@ubuntu:~/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_$ valgrind ./test | grep -v 'are identical'
==34252== Memcheck, a memory error detector
==34252== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==34252== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==34252== Command: ./test
==34252== 
==34252== Conditional jump or move depends on uninitialised value(s)
==34252==    at 0x4EFAE19: GIntegral::polint(double*, double*, int, double, double*) (GIntegral.cpp:468)
==34252==    by 0x400EF9: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252== 
==34252== Invalid read of size 8
==34252==    at 0x4EFAE0B: GIntegral::polint(double*, double*, int, double, double*) (GIntegral.cpp:467)
==34252==    by 0x400EF9: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==  Address 0x6efa540 is 0 bytes after a block of size 2,048 alloc'd
==34252==    at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==34252==    by 0x400E87: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252== 
==34252== Conditional jump or move depends on uninitialised value(s)
==34252==    at 0x4EFAF57: GIntegral::polint(double*, double*, int, double, double*) (GIntegral.cpp:489)
==34252==    by 0x400EF9: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252== 
==34252== Conditional jump or move depends on uninitialised value(s)
==34252==    at 0x4EFAF5D: GIntegral::polint(double*, double*, int, double, double*) (GIntegral.cpp:489)
==34252==    by 0x400EF9: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252== 
==34252== Invalid read of size 8
==34252==    at 0x4EFAF20: GIntegral::polint(double*, double*, int, double, double*) (GIntegral.cpp:486)
==34252==    by 0x400EF9: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==  Address 0x6efa540 is 0 bytes after a block of size 2,048 alloc'd
==34252==    at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==34252==    by 0x400E87: GIntegral_SubClass::polint_Wrapper() (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252==    by 0x400D6A: main (in /home/deil/software/code/gammalib_sanity/tests/libgamma/0.0/groups/GIntegral/classes/GIntegral/_ZN9GIntegral6polintEPdS0_idS0_/test)
==34252== 
==34252== 
==34252== HEAP SUMMARY:
==34252==     in use at exit: 6,040 bytes in 58 blocks
==34252==   total heap usage: 219 allocs, 161 frees, 21,263 bytes allocated
==34252== 
==34252== LEAK SUMMARY:
==34252==    definitely lost: 4,136 bytes in 3 blocks
==34252==    indirectly lost: 8 bytes in 1 blocks
==34252==      possibly lost: 1,640 bytes in 46 blocks
==34252==    still reachable: 256 bytes in 8 blocks
==34252==         suppressed: 0 bytes in 0 blocks
==34252== Rerun with --leak-check=full to see details of leaked memory
==34252== 
==34252== For counts of detected and suppressed errors, rerun with: -v
==34252== Use --track-origins=yes to see where uninitialised values come from
==34252== ERROR SUMMARY: 65792 errors from 5 contexts (suppressed: 2 from 2)

So the api-sanity-checker only runs the tests and looks for segfaults, but really we want to check for memory errors and it’s random if those trigger segfaults or not.

Should I write a small script to run valgrind on all tests (not only the api-sanity-checker) and summarizes the results?
(I thought I had seen valgrind already on your Jenkins, but now I can’t find it!?)