Action #758

Feature #754: Allow fitting of elliptical morphology shapes

Adapt GResponse to support elliptical models

Added by Knödlseder Jürgen almost 12 years ago. Updated about 11 years ago.

Status:ClosedStart date:02/16/2013
Priority:NormalDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-Estimated time:0.00 hour
Target version:1.0.0
Duration:

Description

So far, GResponse only handles point sources, radial models and diffuse models. The following mapping exists:
  • Spatial models of type GModelSpatialPtsrc call GResponse::irf_ptsrc and GResponse::npred_ptsrc
  • Spatial models of type GModelRadial call GResponse::irf_extended and GResponse::npred_extended
  • All other models call GResponse::irf_diffuse and GResponse::npred_diffuse
To accomodate for elliptical models, a more direct mapping should be implemented:
  • GModelSpatialPtsrc: call GResponse::irf_ptsrc and GResponse::npred_ptsrc
  • GModelRadial: call GResponse::irf_radial and GResponse::npred_radial
  • GModelElliptical: call GResponse::irf_elliptical and GResponse::npred_elliptical
  • All other models call GResponse::irf_diffuse and GResponse::npred_diffuse

Since this implies an interface change, all derived response classes need also to be adapted.

Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen almost 12 years ago

  • Subject changed from Implement elliptical models in GResponse to Adapt GResponse to support elliptical models
  • Description updated (diff)

#2 Updated by Knödlseder Jürgen almost 12 years ago

  • Target version set to HESS sprint #1

#3 Updated by Knödlseder Jürgen almost 12 years ago

  • Status changed from New to In Progress
  • Assigned To set to Knödlseder Jürgen

Start implementation.

#4 Updated by Knödlseder Jürgen almost 12 years ago

  • % Done changed from 0 to 50

The new spatial model organization is now supported. We still need to implement a default method for npred_elliptical.

#5 Updated by Knödlseder Jürgen almost 12 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 50 to 100
  • Remaining (hours) set to 0.0

Implement GResponse::npred_elliptical, not tested.

I’m not sure if this method is really useful as no ROI handling is implemented here. Maybe all integration methods should be removed from GResponse as they do not seem to be really useful. Alternatively, one may think about modifying the methods to take into account the ROI.

See #766.

#6 Updated by Knödlseder Jürgen over 11 years ago

  • Target version changed from HESS sprint #1 to 00-08-00

#7 Updated by Knödlseder Jürgen about 11 years ago

  • Status changed from Feedback to Closed
  • Estimated time set to 0.00

#8 Updated by Knödlseder Jürgen about 11 years ago

  • Target version deleted (00-08-00)

#9 Updated by Knödlseder Jürgen over 10 years ago

  • Target version set to 1.0.0

Also available in: Atom PDF