Feature #762
Reorganize sky models
| Status: | Closed | Start date: | 02/17/2013 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned To: |  Knödlseder Jürgen | % Done: | 100% | |
| Category: | - | Estimated time: | 12.00 hours | |
| Target version: | 00-08-00 | |||
| Duration: |
Description
The sky models have actually a double logic, with major spatial classes such as point source, extended models and diffuse models that reflect themselves in the implementation of the GModelSky class. This is not really necessary.
GModelSky should therefore become a real class instead of an abstract class, and the derived classes GModelPointSource, GModelExtendedSource and GModelDiffuseSource should be removed. The GModelSky::type method needs to be implemented for this purpose, and the method should return the type string dependent on the spatial model type.
GModelSpatial should be declinated in the following derived classes:
GModelSpatialPointSourceGModelSpatialRadialGModelSpatialEllipticalGModelSpatialDiffuse
The GModelSpatialPointSource is the existing GModelSpatialPtsrc class that simply needs to be renamed, all other classes are abstract base classes from which the particular spatial models derived. Below a graphical representation of the new organization.
Recurrence
No recurrence.
Subtasks
History
#1
Updated by Knödlseder Jürgen about 11 years ago
- File spatial-reorganisation.jpg added
- Description updated (diff)
#2
Updated by Knödlseder Jürgen about 11 years ago
- Assigned To set to Knödlseder Jürgen
#3
Updated by Knödlseder Jürgen about 11 years ago
- Due date set to 02/17/2013
- Start date set to 02/17/2013
due to changes in a related task
#4
Updated by Mayer Michael about 11 years ago
That sounds like a good plan. The structure becomes more transparent.
#5
Updated by Knödlseder Jürgen about 11 years ago
- File GModel-new.jpg added
- File GModelSpatial-new.jpg added
- Status changed from New to Feedback
The sky models have been reorganized. The new top level organization of GModel is shown below:
GModelSky is no longer abstract, the classes GModelPointSource, GModelExtendedSource and GModelDiffuseSource have been removed.
The new organization of the spatial component GModelSpatial is shown below:
Note that all classes have been renamed, so existing code needs to be adapted to the new naming scheme. All radial models derive now from GModelSpatialRadial while all diffuse models derive from GModelSpatialDiffuse. The way is now open to implement elliptical models, starting with the implementation of the GModelSpatialElliptical base class (see #755, and also #754).
#6
Updated by Knödlseder Jürgen about 11 years ago
All code now in devel branch.
#7
Updated by Knödlseder Jürgen over 10 years ago
- Status changed from Feedback to Closed