Action #769

Feature #692: Perform an extensive interface review of all classes

Review xml module classes

Added by Knödlseder Jürgen over 11 years ago. Updated almost 11 years ago.

Status:ClosedStart date:01/12/2013
Priority:NormalDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-Estimated time:10.00 hours
Target version:00-08-00
Duration:

Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen over 11 years ago

The following classes have been reviewed:
Class Comment
GXml Derive from GContainer, implement container methods, pass nodes by reference instead of pointers.
GXmlNode Derive from GContainer, implement container methods, pass nodes by reference instead of pointers.
GXmlAttribute Checked using example scripts
GXmlComment Checked using example scripts
GXmlDocument Checked using example scripts
GXmlElement Checked using example scripts, add attribute removal method
GXmlPI Checked using example scripts
GXmlText Checked using example scripts, add text retrieval method

#2 Updated by Knödlseder Jürgen over 11 years ago

  • Status changed from New to In Progress
  • Assigned To set to Knödlseder Jürgen
  • % Done changed from 0 to 20

The review has been started in course of the URL implementation (see #800). Index parameters are now declared as const references, the documentation has been improved.

#3 Updated by Knödlseder Jürgen over 11 years ago

  • Remaining (hours) changed from 10.0 to 8.0

#4 Updated by Knödlseder Jürgen over 11 years ago

  • % Done changed from 20 to 60
  • Remaining (hours) changed from 8.0 to 4.0

#5 Updated by Knödlseder Jürgen over 11 years ago

  • % Done changed from 60 to 80
  • Remaining (hours) changed from 4.0 to 2.0

A chief review if all remaining classes has been performed. What is still missing is a review of all comments and documentation. The interfaces appear now pretty okay.

#6 Updated by Knödlseder Jürgen over 11 years ago

We need a method for deleting attributed from a GXmlElement.

#7 Updated by Knödlseder Jürgen over 11 years ago

  • % Done changed from 80 to 90
  • Remaining (hours) changed from 2.0 to 1.0

Jürgen Knödlseder wrote:

We need a method for deleting attributed from a GXmlElement.

I added the remove_attribute() method for this purpose.

#8 Updated by Knödlseder Jürgen over 11 years ago

Example scripts have been implemented that test all functionalities of the XML document handling classes. We can now be pretty sure that the interface provides at least all methods necessary for XML handling. So the interface handling is now basically finished.

The only remaining issue is a review of the class description in the header files and a review of all method descriptions in the source files.

#9 Updated by Knödlseder Jürgen over 11 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 90 to 100
  • Remaining (hours) changed from 1.0 to 0.0

Done.

#10 Updated by Knödlseder Jürgen almost 11 years ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF