Action #770
Feature #692: Perform an extensive interface review of all classes
Review obs module classes
| Status: | Closed | Start date: | 02/20/2013 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned To: |  Knödlseder Jürgen | % Done: | 100% | |
| Category: | - | Estimated time: | 20.00 hours | |
| Target version: | 00-08-00 | |||
| Duration: |
Recurrence
No recurrence.
History
#1
Updated by Knödlseder Jürgen over 11 years ago
The following classes have been reviewed:
| Class | Comment | |||
GEbounds |
Derive from GContainer, modify setlin and setlog, add interval constructor, implement container methods, read and write methods now take references instead of pointers |
|||
GEnergy |
Add energy constructor. | |||
GEvent |
No modifications | |||
GEventAtom |
Use inline methods | |||
GEventBin |
Use inline methods | |||
GEvents |
Define clobber as const reference in save(), remove event iterator | |
GEventCube |
Define clobber as const reference in save(), define axis as const reference in naxis() |
GEventList |
Define clobber as const reference in save() | |||
GGti |
Derive from GContainer, implement container methods, read and write methods now take references instead of pointers, declare clobber as const reference in save() method |
|||
GInstDir |
No modifications | |||
GObservation |
events() set now takes a const reference, response() not returns a const reference | |||
GObservations |
Derive from GContainer, implement container methods, append() now takes const reference, models() returns cost reference, remove non-const operator[], add set() method. |
|||
GObservationRegistry |
No changes | |||
GPhoton |
Add mcid argument to photon constructor | |||
GPhotons |
Derive from GContainer, implement container methods. |
|||
GPointing |
Removed base class | |||
GResponse |
No modification | |||
GRoi |
No modification | |||
GSource |
No modification | |||
GTime |
sec() method returns const reference | |||
GTimes |
Derive from GContainer, implement container methods. |
|||
GTimeReference |
Read and write methods now take references instead of pointers |
#2
Updated by Knödlseder Jürgen over 11 years ago
- Status changed from New to In Progress
#3
Updated by Knödlseder Jürgen over 11 years ago
- Assigned To set to Knödlseder Jürgen
- % Done changed from 0 to 10
- Estimated time set to 20.00
- Remaining (hours) set to 20.0
#4
Updated by Knödlseder Jürgen over 11 years ago
- % Done changed from 10 to 20
With reworking the GObservations class a major step forward has been achieved.
#5
Updated by Knödlseder Jürgen over 11 years ago
- Remaining (hours) changed from 20.0 to 15.0
#6
Updated by Knödlseder Jürgen over 11 years ago
- % Done changed from 20 to 40
- Remaining (hours) changed from 15.0 to 11.0
All container classes of the observation module have now been implemented.
#7
Updated by Knödlseder Jürgen over 11 years ago
Add index() method to abstract GEvent class so that every event can tell where it is located in a list. If the event is not in a list, the index() method should return -1.
This logic opens up the way for optimized implementations of instrument specific event classes.
#8
Updated by Knödlseder Jürgen almost 11 years ago
- Status changed from In Progress to Closed
- % Done changed from 40 to 100
- Remaining (hours) changed from 11.0 to 0.0
Interface review finished.