GammaLib

There’s a test fail for ctools:
https://gist.github.com/cdeil/e6fb9ed0209487d48af2#file-gistfile1-txt-L36

Even if I add this:
https://github.com/cdeil/gammalib/commit/986f976a38e07b5f70f718daa4abd97c3d0b922d
I think still the setitem(string, int) is called if a bool is passed in?

Jürgen, can you have a look, please?

I have done some additional modifications to the Python interface, please see the GApplication.i file. I think this takes now care of all the special issues, and also deals with Boolean parameters (this is however not 100% clean as a Boolean seems to be presented by an integer value; hence you can set for example sim["ra"] = True - I would be happy if I could catch this).

Agreed it’s bad to accept sim[“ra”] = True.

I’ve never used this, but probably the solution is to do input checking in Python using e.g. pythonprepend?
http://www.swig.org/Doc3.0/SWIGDocumentation.html#Python_nn42

I note that swig changed the bool behavior, but this was switched of by specifying the -DSWIG_PYTHON_LEGACY_BOOL flag. I could not find any trace of why I used this option.

Looks like I introduced the -DSWIG_PYTHON_LEGACY_BOOL because this resulted in some test errors, but by changing the test scripts this could be fixed:

test_GApplication.py:
        #ref.append("1\n")
        ref.append("true\n") # New swig version

test_GFits.py:
            #col1[i] = i % 2
            #col2[i] = i % 2
            col1[i] = bool(i % 2)  # New swig version
            col2[i] = bool(i % 2)  # New swig version

I now added a __setitem__(const std::string& name, const bool& val) method to GApplication and disallowed setting of a boolean parameter with an integer value. This results in the expected behavior:

>>> import ctools
>>> sim=ctools.ctobssim()
>>> sim["ra"]=True
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/gamma/lib/python2.6/site-packages/gammalib/app.py", line 280, in __setitem__
    return _app.GApplication___setitem__(self, *args)
RuntimeError: *** ERROR in __setitem__(std::string, int): Invalid argument. Attempt to set "r" parameter "ra" with boolean value "1".
>>> sim["clobber"]=False
>>> sim["clobber"]=1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/gamma/lib/python2.6/site-packages/gammalib/app.py", line 280, in __setitem__
    return _app.GApplication___setitem__(self, *args)
RuntimeError: *** ERROR in __setitem__(std::string, int): Invalid argument. Attempt to set "b" parameter "clobber" with integer value "1".
>>> sim["clobber"]=0
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/gamma/lib/python2.6/site-packages/gammalib/app.py", line 280, in __setitem__
    return _app.GApplication___setitem__(self, *args)
RuntimeError: *** ERROR in __setitem__(std::string, int): Invalid argument. Attempt to set "b" parameter "clobber" with integer value "0".