Change request #1652

ctbkgcube should file a warning if no background model is provided

Added by Mayer Michael about 8 years ago. Updated almost 7 years ago.

Status:ClosedStart date:01/30/2016
Priority:HighDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-
Target version:1.3.0
Duration:

Description

Julien Lefaucheur reported the following problem:
in case no background model (GCTAIrfBackground) is provided in the model XML file which is fed to ctbkgcube, the output background cube will be empty.
The problem is that no warning or exception comes up and the output looks normal:

2016-01-29T12:23:14: +==========================+
2016-01-29T12:23:14: | Generate background cube |
2016-01-29T12:23:14: +==========================+
2016-01-29T12:23:14: Including HESS observation "Crab" (id=00023523) in background cube computation.
2016-01-29T12:23:14: Including HESS observation "Crab" (id=00023526) in background cube computation.
2016-01-29T12:23:14: Including HESS observation "Crab" (id=00023559) in background cube computation.
2016-01-29T12:23:14: Including HESS observation "Crab" (id=00023592) in background cube computation.
2016-01-29T12:23:14: 
2016-01-29T12:23:14: +==============+
2016-01-29T12:23:14: | Output model |
2016-01-29T12:23:14: +==============+
2016-01-29T12:23:14: === GModels ===
...

We should adapt 'ctbkgcube’ to throw a meaningful exception or warning in such cases.

Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen almost 8 years ago

  • Target version set to 1.2.0

#2 Updated by Knödlseder Jürgen about 7 years ago

  • Priority changed from Normal to High
  • Target version changed from 1.2.0 to 1.3.0

#3 Updated by Knödlseder Jürgen almost 7 years ago

  • Status changed from New to In Progress
  • Assigned To set to Knödlseder Jürgen
  • % Done changed from 0 to 90

I added an exception in case that no background is present in the model container.

#4 Updated by Knödlseder Jürgen almost 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

Merged into devel

Also available in: Atom PDF