ctools

And after a successful run, the following Python code leads to an exception:

bin.clear()         # <== Segfaults
libc++abi.dylib: terminating with uncaught exception of type GException::par_file_open_error: *** ERROR in GApplicationPars::write(std::string&): Unable to open parameter file "pfiles/".
Test ctbin from Python: ...................................../test_python_ctools.sh: line 25: 93462 Abort trap: 6           ./test_

Check test_ctbin.py to reproduce the problems.

A similar problem seems to exist with ctcubemask. The following code produces an exception:

mask.clear()
libc++abi.dylib: terminating with uncaught exception of type GException::par_file_open_error: *** ERROR in GApplicationPars::write(std::string&): Unable to open parameter file "pfiles/".
Test ctcubemask from Python: .....F./test_python_ctools.sh: line 25: 72729 Abort trap: 6           ./test_python_ctools.py

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib            0x00007fff8f553f06 __pthread_kill + 10
1   libsystem_pthread.dylib           0x00007fff9a27d4ec pthread_kill + 90
2   libsystem_c.dylib                 0x00007fff955d46df abort + 129
3   libc++abi.dylib                   0x00007fff8ca57c11 abort_message + 257
4   libc++abi.dylib                   0x00007fff8ca7ddff default_terminate_handler() + 243
5   libobjc.A.dylib                   0x00007fff962e86c3 _objc_terminate() + 124
6   libc++abi.dylib                   0x00007fff8ca7b00e std::__terminate(void (*)()) + 8
7   libc++abi.dylib                   0x00007fff8ca7b083 std::terminate() + 51
8   libctools.2.dylib                 0x000000010d2710af ctcubemask::~ctcubemask() + 15 (ctcubemask.cpp:128)
9   _tools.so                         0x000000010d205a56 _wrap_delete_ctcubemask(_object*, _object*) + 102 (tools_wrap.cpp:1447)
10  org.python.python                 0x000000010b579eb0 PyObject_Call + 99
11  org.python.python                 0x000000010b57648c PyObject_CallFunctionObjArgs + 190
12  _tools.so                         0x000000010d20da4d SwigPyObject_dealloc(_object*) + 445 (tools_wrap.cpp:1721)
13  org.python.python                 0x000000010b5a5567 dict_dealloc + 129
14  org.python.python                 0x000000010b5c586c subtype_dealloc + 575
15  org.python.python                 0x000000010b5965c2 frame_dealloc + 110
16  org.python.python                 0x000000010b5f32c1 PyEval_EvalCodeEx + 2047
17  org.python.python                 0x000000010b597fb1 function_call + 352
18  org.python.python                 0x000000010b579eb0 PyObject_Call + 99
19  org.python.python                 0x000000010b584cb8 instancemethod_call + 173
20  org.python.python                 0x000000010b579eb0 PyObject_Call + 99
21  org.python.python                 0x000000010b5fd06f PyEval_CallObjectWithKeywords + 165
22  _test.so                          0x000000010cc6244e GPythonTestSuite::test() + 110 (test_wrap.cpp:3892)
23  libgamma.2.dylib                  0x000000010bcdddd2 GTestSuite::run() + 674 (GTestSuite.cpp:319)
24  libgamma.2.dylib                  0x000000010bce1ac9 GTestSuites::run() + 681 (GTestSuites.cpp:461)
25  _test.so                          0x000000010cc51f5a _wrap_GTestSuites_run(_object*, _object*) + 90 (test_wrap.cpp:3443)
26  org.python.python                 0x000000010b5f9bcd PyEval_EvalFrameEx + 26858
27  org.python.python                 0x000000010b5fd72d fast_function + 264
28  org.python.python                 0x000000010b5f9af3 PyEval_EvalFrameEx + 26640
29  org.python.python                 0x000000010b5f30f1 PyEval_EvalCodeEx + 1583
30  org.python.python                 0x000000010b5fd69a fast_function + 117
31  org.python.python                 0x000000010b5f9af3 PyEval_EvalFrameEx + 26640
32  org.python.python                 0x000000010b5f30f1 PyEval_EvalCodeEx + 1583
33  org.python.python                 0x000000010b5f2abc PyEval_EvalCode + 54
34  org.python.python                 0x000000010b616ea1 run_mod + 53
35  org.python.python                 0x000000010b616f44 PyRun_FileExFlags + 133
36  org.python.python                 0x000000010b616a93 PyRun_SimpleFileExFlags + 698
37  org.python.python                 0x000000010b628445 Py_Main + 3137
38  libdyld.dylib                     0x00007fff857105ad start + 1

ctbkgcube::~ctbkgcube(void)
{
    // Free members
    free_members();

    // Return
    return;
}

I added some code to GApplication::clear() to preserve the name and version of the tool. Now all ctools need the following code in their clear method:

void ctcubemask::clear(void)
{
    // Free members
    free_members();
    this->ctool::free_members();

    // Clear base class (needed to conserve tool name and version)
    this->GApplication::clear();

    // Initialise members
    this->ctool::init_members();
    init_members();

    // Write header into logger
    log_header();

    // Return
    return;
}

Solving the save() method problem was quite trivial: needed to add a test on observation container emptiness:

    if (!m_outcube.is_empty() && m_obs.size() > 0) {
       GCTAObservation* obs = dynamic_cast<GCTAObservation*>(m_obs[0]);

The publish() problem was related to a GammaLib problem in the GSkyMap::publish() method. The method segfaulted in fact for an empty sky map.

The GSkyMap::write() method has been modified to return now a pointer to the written (or appended) HDU. In case that nothing is written, the method returns a NULL pointer.

The GSkyMap::publish() checks for a NULL pointer, and simply does nothing in case that a NULL pointer is encountered.