Change request #1845

Use 'NONE' instead of 0.0 for unapplied selection values in ctselect

Added by Knödlseder Jürgen over 7 years ago. Updated over 6 years ago.

Status:ClosedStart date:08/13/2016
Priority:HighDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-
Target version:1.5.0
Duration:

Description

If the emin or emax value is set to 0.0 in ctselect the tool will ignore the event selection. This is not very understandable for users. Instead, 'NONE’ should be used (or 'UNDEF’) to specify an ignored event selection parameter.

Note that the unit test also needs to be modified, since it actually checks the current logic.


Recurrence

No recurrence.

History

#1 Updated by Mayer Michael over 7 years ago

Should we only accept “NONE” and “UNDEF” (maybe also “INDEF”)?

What should be the behaviour when something else invalid e.g. “NOTHING” is entered? Either we throw an exception here, or quietly skip the corresponding selection then.
It boils down to the question if we use GApplicationPar::is_valid() or specifically check for strings like “NONE”.

#2 Updated by Knödlseder Jürgen about 7 years ago

  • Priority changed from Normal to High
  • Target version changed from 1.2.0 to 1.3.0

#3 Updated by Knödlseder Jürgen almost 7 years ago

  • Target version changed from 1.3.0 to 1.4.0

#4 Updated by Knödlseder Jürgen almost 7 years ago

  • Target version changed from 1.4.0 to 1.5.0

Check if this is not already possible.

#5 Updated by Knödlseder Jürgen over 6 years ago

  • Status changed from New to Closed
  • Assigned To set to Knödlseder Jürgen
  • % Done changed from 0 to 100

This is already possible, close the change request now.

Also available in: Atom PDF