ctools

Need also to add energy binning parameters.

Script broken by latest gammalib revision where GCTAOnOffObservation only accepts GSkyRegionMap for region definition. Waiting on Jürgen to change this to finalize.

I integrated the code and did a couple of minor changes.

I changed the exclusion parameter to inexclusion since we decided some time ago to preceed all input file parameters with in while all output file parameters are preceeded with out. I also changed rootobs to prefix for consistency with ctselect.

Furthermore, I put all saving operations into a save() method which is the convention for all ctools and cscripts. If run() is called the ctools or cscripts should never save anything on disk to allow the construction of in-memory pipelines. I also added an obs() method to recover the result observation container from the script in case one want to use it in an in-memory pipeline. I also added a call of save() to execute() which is also the standard way of working (files are saved when execute() is called).

I also avoided storing some of the parameters into global class values since the code quality check always recommends to avoid global class members. Instead they are read on the fly from the parameter interface. To make sure that values are however queried at the beginning, I kept the query logic (meaning that the parameter values are requested once but not stored). For values that are stored I also added initialisations into the init method to make sure that the class is always setup properly. This should catch some of the issues that Sonar will come up

Finally, the DS9 On region is only stored once since the On region is the same for all observations. I also slightly adapted the file names.

I updated the unit test to take the changes I made into account and all tests passed.

Code is currently in the integration pipeline.

The Python string.format() directive posed some problems on some of the platforms during the integration tests (CentOS 6, Debian 6, OpenSolaris, Scientific Linux 6).

The Python string.format() was apparently introduced in Python 2.6, but seems to have evolved for Python 2.7. I replaced the format directives by the classical % directives to assure that the code also works on the older Python versions.