Bug #2883

csresspec does not work correctly for per observation background model in stacked mode for On/Off observations

Added by Knödlseder Jürgen almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:05/05/2019
Priority:NormalDue date:
Assigned To:Knödlseder Jürgen% Done:

100%

Category:-
Target version:1.6.0
Duration:

Description

When running csresspec in stacked mode for On/Off observations with a background model per observation the script overestimates the background.

The reason is that csresspec stacks the observations in the run() method, but then uses the original model container, effectively adding each background model component for the stacked observation. We need to stack differently after computing the source and model components, so that the models are correctly taken into account.

Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen almost 5 years ago

  • Status changed from New to Pull request
  • Assigned To set to Knödlseder Jürgen
  • % Done changed from 0 to 100

Instead of stacking the observations the residuals are now stacked, allowing to use observation specific models in the computation.

The code was moved to the integration branch.

#2 Updated by Knödlseder Jürgen almost 5 years ago

  • Status changed from Pull request to Closed

Merged into devel.

Also available in: Atom PDF