Feature #1145

ctobssim should also fill the DETX and DETY columns

Added by Knödlseder Jürgen almost 11 years ago. Updated about 10 years ago.

Status:ClosedStart date:02/13/2014
Priority:NormalDue date:
Assigned To:Mayer Michael% Done:

100%

Category:-
Target version:1.0.0
Duration:

Description

Everything is in the title.


Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen almost 11 years ago

  • Tracker changed from Change request to Feature
  • Remaining (hours) set to 0.0

#2 Updated by Knödlseder Jürgen over 10 years ago

  • Target version changed from 00-07-02 to 1.0.0

#3 Updated by Mayer Michael about 10 years ago

If I am not mistaken, this issue is easily solvable by slightly changing GCTAResponseIrf::mc(), which is called from ctobssim::simulate_background().

When setting up the GCTAInstDir object in GCTAResponseIrf::mc(), we could do:

GCTAInstDir inst_dir = pnt.instdir(sky_dir);

instead of currently:
GCTAInstDir inst_dir;
inst_dir.dir(sky_dir);

The latter does not set DETX and DETY, while the former does. I made a quick test and the columns where filled correctly. The fix is available on branch 1145-fill-detx-dety-from-ctobssim.

#4 Updated by Mayer Michael about 10 years ago

The fix is available on branch 1145-fill-detx-dety-from-ctobssim

... in the gammalib repo

#5 Updated by Knödlseder Jürgen about 10 years ago

  • Status changed from New to Closed
  • Assigned To set to Mayer Michael
  • % Done changed from 0 to 100

Merged into devel branch.

Also available in: Atom PDF