Action #1288

ctmodel doesn't work for GCTABackground3D

Added by Lu Chia-Chun over 10 years ago. Updated over 9 years ago.

Status:RejectedStart date:07/21/2014
Priority:HighDue date:
Assigned To:Knödlseder Jürgen% Done:

10%

Category:-Estimated time:0.00 hour
Target version:1.0.0
Duration:

Description

It throws no error messages but gives maps filled with zero.

Recurrence

No recurrence.

Related issues

Related to GammaLib - Change request #1197: Gammlib should check consistency of model and observation... New 05/09/2014

History

#1 Updated by Lu Chia-Chun over 10 years ago

  • Status changed from New to Resolved

same problem as #1197. The model instrument doesn’t match the observation instrument name...(in obs, I used “CTA” and in model “HESS”.)

I think this is a mistake people can easily make. Can’t we do something ? At least throwing some warning messages?

#2 Updated by Knödlseder Jürgen over 10 years ago

  • Status changed from Resolved to In Progress
  • Target version set to 00-08-00
  • % Done changed from 0 to 10

What should we do about this? How can ctmodel “guess” what the user wants to do and signal that he/she made an error?

I guess that ctmodel should create no model map in case that no corresponding model was found, and write a corresponding warning into the log file. Would this have helped you to fix the problem? (if yes I’ll go ahead and make the change)

#3 Updated by Knödlseder Jürgen over 10 years ago

  • Status changed from In Progress to Rejected
  • Target version deleted (00-08-00)
  • Remaining (hours) set to 0.0

I reject that issue as we have already #1197 for the same problem.

#4 Updated by Knödlseder Jürgen over 10 years ago

  • Status changed from Rejected to In Progress
  • Assigned To set to Knödlseder Jürgen
  • Target version set to 00-08-00
  • Estimated time set to 0.00

Re-open as #1197 was for ctlike while this issue is for ctmodel (same underlying problem but affects different systems).

#5 Updated by Lu Chia-Chun over 10 years ago

I guess this is probably the best solution:

if ( user == “Chia-Chun”):
print “WARNING! Check the instrument name in your model. It probably doesn’t match the observation!”

Knödlseder Jürgen wrote:

What should we do about this? How can ctmodel “guess” what the user wants to do and signal that he/she made an error?

I guess that ctmodel should create no model map in case that no corresponding model was found, and write a corresponding warning into the log file. Would this have helped you to fix the problem? (if yes I’ll go ahead and make the change)

#6 Updated by Knödlseder Jürgen about 10 years ago

Action: add some check to ctmodel and dump warning if no relevant model was found.

#7 Updated by Knödlseder Jürgen about 10 years ago

  • Target version changed from 00-08-00 to 1.0.0

#8 Updated by Knödlseder Jürgen over 9 years ago

  • Status changed from In Progress to Rejected

As this is a user problem, we don’t do anything it for now.

Also available in: Atom PDF