Change request #1298

Cube analysis tools should complain about missing ROI information.

Added by Knödlseder Jürgen almost 10 years ago. Updated almost 9 years ago.

Status:ClosedStart date:07/25/2014
Priority:NormalDue date:
Assigned To:Mayer Michael% Done:

100%

Category:-
Target version:1.0.0
Duration:

Description

The cube analysis tools ctbin, ctexpcube, ctpsfcube and ctbkgcube need RoI information. So far the tools do not complain when this information is missing in the headers of the event files.

Recurrence

No recurrence.

History

#1 Updated by Knödlseder Jürgen almost 10 years ago

  • Subject changed from Cube analysis tools should complain of missing ROI information. to Cube analysis tools should complain about missing ROI information.

#2 Updated by Knödlseder Jürgen over 9 years ago

  • Target version set to 1.0.0

#3 Updated by Mayer Michael almost 9 years ago

I guess we already have this in ctbin. Here we check for the sanity of the RoI:

// Check for RoI sanity
if (!roi.is_valid()) {
   std::string msg = "No RoI information found in input observation " 
                      "\""+obs->name()+"\". Run ctselect to specify " 
                      "an RoI for this observation before running " 
                      "ctbin.";
    throw GException::invalid_value(G_FILL_CUBE, msg);
}

I guess, we only need to take these lines of code and implement them in GCTACubeExposure::fill(), GCTACubePsf::fill(), GCTACubeBackground::fill(). I would do it right now if I don’t had a pending pull request on those files :) (see #1439)

#4 Updated by Mayer Michael almost 9 years ago

  • Status changed from New to Pull request
  • Assigned To set to Mayer Michael
  • % Done changed from 0 to 100

Available on branch 1298-add-exception-if-RoI-is-missing

#5 Updated by Knödlseder Jürgen almost 9 years ago

  • Status changed from Pull request to Closed

Now in devel

Also available in: Atom PDF