Change request #1523

cshessobs with Python3.x

Added by Mayer Michael over 8 years ago. Updated over 8 years ago.

Status:ClosedStart date:08/31/2015
Priority:NormalDue date:
Assigned To:Mayer Michael% Done:

100%

Category:-
Target version:1.0.0
Duration:

Description

Christoph noted that cshessobs doesn’t work with Python3.x. The reason is that apparently python dictionaries lost the function has_key.
I therefore propose to replace the call of these functions to a more pythonic way using:

if key in dict:

instead of
if dict.has_key(key):


Recurrence

No recurrence.

History

#1 Updated by Mayer Michael over 8 years ago

  • Status changed from New to Pull request
  • Assigned To set to Mayer Michael

Available von branch 1523-cshessobs-python3x.

#2 Updated by Deil Christoph over 8 years ago

Alternative fix: https://github.com/ctools/ctools/compare/devel...cdeil:issue-1522

:P

(IMO having cshessobs as an untested and undocumented second-class script that hardcodes HESS a data management scheme is a bad idea.)

#3 Updated by Knödlseder Jürgen over 8 years ago

  • Status changed from Pull request to Closed
  • Target version set to 1.0.0
  • % Done changed from 0 to 100

Merged into devel.

Also available in: Atom PDF