ctools

I’ve nested several scripts that have to run many times, so setting the chatter=0 is useful to prevent flooding the screen with information. However, ctpsfcube does not appear to respect this mode. As an example, I would not expect the 'Skipping unbinned ...' lines to be included in the following output:

COMMAND:
$ ctpsfcube debug=yes inobs=myobs.xml outcube=psfcube.fits ebinalg=LOG emin=0.1 emax=100 enumbins=20 
nxpix=5 nypix=5 binsz=0.5 coordsys=GAL proj=CAR xref=358.30 yref=2.83 chatter=0

OUTPUT:

2017-10-26T13:12:43: Skipping unbinned CTA observation "GPS" (id=110323) since it does not overlap with the point spread function cube.
2017-10-26T13:12:43: Skipping unbinned CTA observation "GPS" (id=110324) since it does not overlap with the point spread function cube.
2017-10-26T13:12:43: Skipping unbinned CTA observation "GPS" (id=110325) since it does not overlap with the point spread function cube.
...
2017-10-26T13:12:43: Skipping unbinned CTA observation "GPS" (id=111232) since it does not overlap with the point spread function cube.
2017-10-26T13:12:43: Skipping unbinned CTA observation "GPS" (id=111233) since it does not overlap with the point spread function cube.
2017-10-26T13:12:43: Skipping unbinned CTA observation "GPS" (id=111234) since it does not overlap with the point spread function cube.
2017-10-26T13:12:44: 
2017-10-26T13:12:44: Application "ctpsfcube" terminated after 8 wall clock seconds, consuming 5.14838 seconds of CPU time.

The reason is pretty straight forward. These lines are printed by the 'GCTACubePsf::fill()' method, which takes a pointer to the log file. The output is then directly fed to the log file regardless of the chatter level of the calling tool. Instead, a similar approach should be used as ctbkgcube, where when the chatter is not NORMAL then NULL is passed instead of the log file which prevents any text being logged when looping through the observations:

    // Set pointer to logger dependent on chattiness
    GLog* logger = (logNormal()) ? &log : NULL;

    // Fill background cube from observations
    m_background.fill(m_obs, logger);

There are already protections in 'GCTACubePsf::fill()' to prevent printing when the logfile is NULL, so this is really just the addition of a single line in ctpsfcube.