Bug #2762
ctulimit fails with 1.6.0 dev1 when the best fit parameter hits its lowest allowed value
| Status: | Closed | Start date: | 11/20/2018 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned To: |  Knödlseder Jürgen | % Done: | 100% | |
| Category: | - | |||
| Target version: | 1.6.0 | |||
| Duration: |
Description
Doing some analysis for putting an upper limit on Dark Matter flux with 1.6.0 dev1 version of the ctools we noticed an issue with ctulimit which was not there in previous stable versions. Namely, when the fit for some parameter hits its lowest allowed value, which was zero in our case (ctulimit.log), ctulimit fails to calculate the upper limit. It is trying to find a limit in [0;0] range and obviously fails.
Recurrence
No recurrence.
History
#1
Updated by Knödlseder Jürgen almost 6 years ago
- Project changed from GammaLib to ctools
#2
Updated by Knödlseder Jürgen almost 6 years ago
- Target version set to 1.6.0
#3
Updated by Knödlseder Jürgen over 5 years ago
- Status changed from New to Pull request
- Assigned To set to Knödlseder Jürgen
- % Done changed from 0 to 100
The issue was that in case that the parameter error was larger than the parameter value, the error was set to the value, which means that in case for a value of zero, the error was zero. This resulted in a bracketing range of [0,0].
I do not see any good reason to set the parameter error to the value in case that it is larger to the value. Therefore, I removed the additional code that led to this feature.
#4
Updated by Knödlseder Jürgen over 5 years ago
- Status changed from Pull request to Closed
Code was merged into devel.